flo/todo.txt-cli
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Refactoring: Extract make_action into actions-test-lib.sh.

Browse Source 
This reduces the duplication in the individual test files.
This commit is contained in:
Ingo Karkat
2012-04-27 12:42:10 +02:00
parent 42424d5881
commit 99e5e57a75
5 changed files with 22 additions and 51 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
tests/actions-test-lib.sh Executable file
View File

@@ -0,0 +1,18 @@
#!/bin/bash
make_action()
{
unset TODO_ACTIONS_DIR
[ -d .todo.actions.d ] || mkdir .todo.actions.d
cat > ".todo.actions.d/$1" <<EOF
#!/bin/bash
[ "\$1" = "usage" ] && {
echo " $1 ITEM#[, ITEM#, ...] [TERM...]"
echo " This custom action does $1."
echo ""
exit
}
echo "custom action $1"
EOF
chmod +x ".todo.actions.d/$1"
}

13
tests/t2100-help.sh
View File

@@ -5,10 +5,9 @@ test_description='help functionality
This test covers the help output. This test covers the help output.
' '
. ./actions-test-lib.sh
. ./test-lib.sh . ./test-lib.sh
unset TODO_ACTIONS_DIR
# Note: To avoid having to adapt the test whenever the help documentation # Note: To avoid having to adapt the test whenever the help documentation
# slightly changes, only check for the section headers. # slightly changes, only check for the section headers.
test_todo_session 'help output' <<EOF test_todo_session 'help output' <<EOF
@@ -33,16 +32,6 @@ test_todo_session 'very verbose help output' <<EOF
Built-in Actions: Built-in Actions:
EOF EOF
mkdir .todo.actions.d
make_action()
{
cat > ".todo.actions.d/$1" <<- EOF
#!/bin/bash
echo "custom action $1"
EOF
chmod +x ".todo.actions.d/$1"
}
make_action "foo" make_action "foo"
test_todo_session 'help output with custom action' <<EOF test_todo_session 'help output with custom action' <<EOF
>>> todo.sh -v help | sed '/^ \w/!d' >>> todo.sh -v help | sed '/^ \w/!d'

12
tests/t8000-actions.sh
View File

@@ -4,19 +4,9 @@ test_description='custom actions functionality
This test covers the contract between todo.sh and custom actions. This test covers the contract between todo.sh and custom actions.
' '
. ./actions-test-lib.sh
. ./test-lib.sh . ./test-lib.sh
unset TODO_ACTIONS_DIR
mkdir .todo.actions.d
make_action()
{
cat > ".todo.actions.d/$1" <<- EOF
#!/bin/bash
echo "custom action $1"
EOF
chmod +x ".todo.actions.d/$1"
}
make_action "foo" make_action "foo"
test_todo_session 'executable action' <<EOF test_todo_session 'executable action' <<EOF
>>> todo.sh foo >>> todo.sh foo

12
tests/t8010-listaddons.sh
View File

@@ -4,19 +4,9 @@ test_description='listaddons functionality
This test checks listing of custom actions. This test checks listing of custom actions.
' '
. ./actions-test-lib.sh
. ./test-lib.sh . ./test-lib.sh
unset TODO_ACTIONS_DIR
mkdir .todo.actions.d
make_action()
{
cat > ".todo.actions.d/$1" <<- EOF
#!/bin/bash
echo "custom action $1"
EOF
chmod +x ".todo.actions.d/$1"
}
test_todo_session 'no custom actions' <<EOF test_todo_session 'no custom actions' <<EOF
>>> todo.sh listaddons >>> todo.sh listaddons
EOF EOF

18
tests/t8020-actions-help.sh
View File

@@ -4,31 +4,15 @@ test_description='actions help functionality
This test checks listing the usage help of a custom action. This test checks listing the usage help of a custom action.
' '
. ./actions-test-lib.sh
. ./test-lib.sh . ./test-lib.sh
unset TODO_ACTIONS_DIR
test_todo_session 'custom action help with no custom action directory' <<'EOF' test_todo_session 'custom action help with no custom action directory' <<'EOF'
>>> todo.sh help foo >>> todo.sh help foo
TODO: No actions directory exists. TODO: No actions directory exists.
=== 1 === 1
EOF EOF
mkdir .todo.actions.d
make_action()
{
cat > ".todo.actions.d/$1" <<EOF
#!/bin/bash
[ "\$1" = "usage" ] && {
echo " $1 ITEM#[, ITEM#, ...] [TERM...]"
echo " This custom action does $1."
echo ""
exit
}
echo "custom action $1"
EOF
chmod +x ".todo.actions.d/$1"
}
make_action "foo" make_action "foo"
make_action "bar" make_action "bar"
make_action "quux" make_action "quux"