BUG: listpri picked up non-priority patterns.

The regexp for the priority wasn't anchored to the beginning of the task. (As the filtering is done inside the _list pipeline, the task number has already been prepended.)
Also, by passing the regexp directly to _list, a case-insensitive search was performed, so despite [A-Z], lowercase characters were picked up, too. Need to make use of post_filter_command to inject a separate, case-sensitive grep into the pipeline.

Bonus: Added test for highlighting of listpri command.
This commit is contained in:
Ingo Karkat
2011-05-10 15:20:29 +02:00
parent a830f18dd5
commit c429b062cf
2 changed files with 44 additions and 2 deletions

View File

@@ -26,4 +26,46 @@ TODO: 0 of 3 tasks shown
--
TODO: 1 of 3 tasks shown
EOF
test_todo_session 'listpri highlighting' <<EOF
>>> todo.sh listpri
1 (B) smell the uppercase Roses +flowers @outside
2 (C) notice the sunflowers
--
TODO: 2 of 3 tasks shown
EOF
cat > todo.txt <<EOF
(B) smell the uppercase Roses +flowers @outside
(C) notice the sunflowers
(m)others will notice this
(n) not a prioritized task
notice the (C)opyright
EOF
test_todo_session 'listpri filtering' <<EOF
>>> todo.sh -p listpri
1 (B) smell the uppercase Roses +flowers @outside
2 (C) notice the sunflowers
--
TODO: 2 of 5 tasks shown
>>> todo.sh -p listpri b
1 (B) smell the uppercase Roses +flowers @outside
--
TODO: 1 of 5 tasks shown
>>> todo.sh -p listpri c
2 (C) notice the sunflowers
--
TODO: 1 of 5 tasks shown
>>> todo.sh -p listpri m
--
TODO: 0 of 5 tasks shown
>>> todo.sh -p listpri n
--
TODO: 0 of 5 tasks shown
EOF
test_done

View File

@@ -1022,9 +1022,9 @@ note: PRIORITY must a single letter from A to Z."
## No priority specified; show all priority tasks
pri="[A-Z]"
fi
pri="($pri)"
_list "$TODO_FILE" "$pri"
post_filter_command="grep '^ *[0-9]\+ (${pri}) '"
_list "$TODO_FILE"
;;
"move" | "mv" )