ENH: Allow listpri filtering with priority ranges.

So far, the listpri action only supports a single priority. Allowing priority ranges (e.g. todo.sh listpri A-C @work) is a simple but useful enhancement.

Note: The syntax extension only clashes with the [TERM] filtering in a few corner cases, and this can be worked around (e.g. "todo.sh listpri A-Z A-Z" lists all prioritized tasks containing the text A-Z).

.gitignore

@@ -1,6 +1,3 @@
 VERSION-FILE
 tests/test-results
 tests/trash\ directory.*
-done.txt
-report.txt
-todo.txt

tests/README

@@ -125,10 +125,10 @@ Writing Tests
 -------------
 
 The test script is written as a shell script.  It should start
-with the standard "#!/bin/bash" with copyright notices, and an
+with the standard "#!/bin/sh" with copyright notices, and an
 assignment to variable 'test_description', like this:
 
-	#!/bin/bash
+	#!/bin/sh
 	#
 	# Copyright (c) 2005 Junio C Hamano
 	#
@@ -186,24 +186,6 @@ library for your script to use.
    expected output.  (See below for how to generate transcripts
    easily.)
 
- - test_todo_completion <message> <cmdline> <completions>
-
-   This takes three strings as parameter.  Based on <cmdline>,
-   the todo_completion script is triggered in the current test
-   environment and completions are compared with <completions>,
-   which should be a space-separated list.  If any completion
-   contains whitespace, quote it; the entire <completions>
-   argument is eval()'ed.
-   Include a trailing space in <cmdline> when you want to check
-   new argument completion; otherwise, completion is triggered
-   with the context of the last argument. <message> should state
-   what it is testing.
-
- - test_todo_custom_completion <completefunc> <message> <cmdline> <completions>
-
-   Same as above, but in addition allows to specify a custom
-   completion function.
-
  - test_tick [interval]
 
    The test harness has an internal view of time which is
@@ -223,13 +205,6 @@ library for your script to use.
 	    'git-write-tree should be able to write an empty tree.' \
 	    'tree=$(git-write-tree)'
 
- - test_expect_code <code> <message> <script>
-
-   This takes an exit status and two strings as parameter, and
-   evaluates the <script>.  If it yields <code>, test is
-   considered successful.  <message> should state what it is
-   testing.
-
  - test_expect_failure <message> <script>
 
    This is NOT the opposite of test_expect_success, but is used

tests/actions-test-lib.sh

@@ -1,18 +0,0 @@
-#!/bin/bash
-
-make_action()
-{
-    unset TODO_ACTIONS_DIR
-    [ -d .todo.actions.d ] || mkdir .todo.actions.d
-    cat > ".todo.actions.d/$1" <<EOF
-#!/bin/bash
-[ "\$1" = "usage" ] && {
-    echo "    $1 ITEM#[, ITEM#, ...] [TERM...]"
-    echo "      This custom action does $1."
-    echo ""
-    exit
-}
-echo "custom action $1"
-EOF
-chmod +x ".todo.actions.d/$1"
-}

tests/t0000-config.sh

@@ -1,4 +1,4 @@
-#!/bin/bash
+#!/bin/sh
 
 test_description='todo.sh configuration file location
 

tests/t0001-null.sh

@@ -1,4 +1,4 @@
-#!/bin/bash
+#!/bin/sh
 
 test_description='todo.sh basic null functionality test.
 

tests/t0002-actions.sh

@@ -1,4 +1,4 @@
-#!/bin/bash
+#!/bin/sh
 
 test_description='todo.sh actions.d
 

tests/t0100-code-nobacktick.sh

@@ -1,4 +1,4 @@
-#!/bin/bash
+#!/bin/sh
 
 test_description='no old-style backtick command substitution
 
@@ -9,15 +9,8 @@ On failure, it will print each offending line number and line.
 '
 . ./test-lib.sh
 
-backtick_check()
-{
-    sed -n -e 's/\(^\|[ \t]\)#.*//' -e '/`/{' -e '=;p' -e '}' "$@"
-}
-
 test_todo_session 'no old-style backtick command substitution' <<EOF
->>> backtick_check bin/todo.sh
+>>> sed -n -e 's/\(^\|[ \t]\)#.*//' -e '/\`/{' -e '=;p' -e '}' "$(which todo.sh)"
-
->>> backtick_check ../../todo.cfg
 EOF
 
 test_done

tests/t1000-addlist.sh

@@ -1,4 +1,4 @@
-#!/bin/bash
+#!/bin/sh
 
 test_description='basic add and list functionality
 

tests/t1010-add-date.sh

@@ -1,4 +1,4 @@
-#!/bin/bash
+#!/bin/sh
 
 test_description='test the date on add feature
 

tests/t1020-addtolistfile.sh

@@ -1,4 +1,4 @@
-#!/bin/bash
+#!/bin/sh
 
 test_description='basic addto and list functionality
 

tests/t1030-addto-date.sh

@@ -1,4 +1,4 @@
-#!/bin/bash
+#!/bin/sh
 
 test_description='test the date on addto feature
 

tests/t1100-replace.sh

@@ -1,4 +1,4 @@
-#!/bin/bash
+#!/bin/sh
 
 test_description='basic replace functionality
 
@@ -164,12 +164,4 @@ TODO: Replaced task with:
 1 (A) 2010-07-04 this also has a new date
 EOF
 
-echo '2009-02-13 this is just a new one' > todo.txt
-test_todo_session 'replace with prepended priority and date replaces existing date' <<EOF
->>> todo.sh replace 1 '(B) 2010-07-04 this also has a new date'
-1 2009-02-13 this is just a new one
-TODO: Replaced task with:
-1 (B) 2010-07-04 this also has a new date
-EOF
-
 test_done

tests/t1200-pri.sh

@@ -1,4 +1,4 @@
-#!/bin/bash
+#!/bin/sh
 
 test_description='basic priority functionality
 '

tests/t1250-listpri.sh

@@ -1,4 +1,4 @@
-#!/bin/bash
+#!/bin/sh
 
 test_description='list priority functionality
 '

tests/t1260-listprj.sh

@@ -0,0 +1,42 @@
+#!/bin/sh
+
+test_description='list project functionality
+'
+. ./test-lib.sh
+
+cat > todo.txt <<EOF
+(B) smell the uppercase Roses +roses @outside +shared
+(C) notice the sunflowers +sunflowers @garden +shared +landscape
+stop
+EOF
+test_todo_session 'basic listproj' <<EOF
+>>> todo.sh listproj
++landscape
++roses
++shared
++sunflowers
+EOF
+
+test_todo_session 'listproj with context' <<EOF
+>>> todo.sh listproj @garden
++landscape
++shared
++sunflowers
+EOF
+
+TEST_TODO_CUSTOM=todo-custom.cfg
+cat todo.cfg > "$TEST_TODO_CUSTOM"
+cat >> "$TEST_TODO_CUSTOM" <<'EOF'
+export DEFAULT='</color>'
+export PRI_B='<color type=green>'
+export PRI_C='<color type=blue>'
+export TODOTXT_FINAL_FILTER='grep -i roses'
+EOF
+test_todo_session 'listproj with context special cases' <<EOF
+>>> todo.sh -+ -d "$TEST_TODO_CUSTOM" listproj @garden
++landscape
++shared
++sunflowers
+EOF
+
+test_done

tests/t1300-ls.sh

@@ -1,4 +1,4 @@
-#!/bin/bash
+#!/bin/sh
 #
 
 test_description='list functionality

tests/t1310-listcon.sh

@@ -1,4 +1,4 @@
-#!/bin/bash
+#!/bin/sh
 #
 
 test_description='listcon functionality
@@ -55,33 +55,4 @@ test_todo_session 'listcon e-mail address test' <<EOF
 @con02
 EOF
 
-cat > todo.txt <<EOF
-(B) smell the uppercase Roses +roses @outside +shared
-(C) notice the sunflowers +sunflowers @garden +shared +landscape
-stop
-EOF
-test_todo_session 'listcon with project' <<EOF
->>> todo.sh listcon +landscape
-@garden
-EOF
-
-cat > todo.txt <<EOF
-@con01 -- Some context 1 task
-EOF
-cat > done.txt <<EOF
-x 2012-02-21 @done01 -- Some context 1 done task
-x 2012-02-21 @done02 -- Some context 2 done task
-EOF
-test_todo_session 'listcon from done tasks' <<'EOF'
->>> TODOTXT_SOURCEVAR=\$DONE_FILE todo.sh listcon
-@done01
-@done02
-EOF
-test_todo_session 'listcon from combined open + done tasks' <<'EOF'
->>> TODOTXT_SOURCEVAR='("$TODO_FILE" "$DONE_FILE")' todo.sh listcon
-@con01
-@done01
-@done02
-EOF
-
 test_done

tests/t1320-listproj.sh

@@ -1,4 +1,4 @@
-#!/bin/bash
+#!/bin/sh
 #
 
 test_description='listproj functionality
@@ -55,63 +55,4 @@ test_todo_session 'listproj embedded + test' <<EOF
 +prj02
 EOF
 
-cat > todo.txt <<EOF
-(B) smell the uppercase Roses +roses @outside +shared
-(C) notice the sunflowers +sunflowers @garden +shared +landscape
-stop
-EOF
-test_todo_session 'basic listproj' <<EOF
->>> todo.sh listproj
-+landscape
-+roses
-+shared
-+sunflowers
-EOF
-
-test_todo_session 'listproj with context' <<EOF
->>> todo.sh listproj @garden
-+landscape
-+shared
-+sunflowers
-EOF
-
-TEST_TODO_CUSTOM=todo-custom.cfg
-cat todo.cfg > "$TEST_TODO_CUSTOM"
-cat >> "$TEST_TODO_CUSTOM" <<'EOF'
-export DEFAULT='</color>'
-export PRI_B='<color type=green>'
-export PRI_C='<color type=blue>'
-export TODOTXT_FINAL_FILTER='grep -i roses'
-EOF
-test_todo_session 'listproj with context special cases' <<EOF
->>> todo.sh -+ -d "$TEST_TODO_CUSTOM" listproj @garden
-+landscape
-+shared
-+sunflowers
-EOF
-
-
-cat > todo.txt <<EOF
-+prj01 -- Some project 1 task
-EOF
-cat > done.txt <<EOF
-x 2012-02-21 +done01 -- Special project 1 done task
-x 2012-02-21 +done02 -- Some project 2 done task
-EOF
-test_todo_session 'listproj from done tasks' <<'EOF'
->>> TODOTXT_SOURCEVAR=\$DONE_FILE todo.sh listproj
-+done01
-+done02
-EOF
-test_todo_session 'listproj from done tasks with filtering' <<'EOF'
->>> TODOTXT_SOURCEVAR=\$DONE_FILE todo.sh listproj Special
-+done01
-EOF
-test_todo_session 'listproj from combined open + done tasks' <<'EOF'
->>> TODOTXT_SOURCEVAR='("$TODO_FILE" "$DONE_FILE")' todo.sh listproj
-+done01
-+done02
-+prj01
-EOF
-
 test_done

tests/t1330-ls-highlighting.sh

@@ -1,4 +1,4 @@
-#!/bin/bash
+#!/bin/sh
 #
 
 test_description='list highlighting

tests/t1350-listall.sh

@@ -1,4 +1,4 @@
-#!/bin/bash
+#!/bin/sh
 
 test_description='listall functionality
 '

tests/t1400-prepend.sh

@@ -1,4 +1,4 @@
-#!/bin/bash
+#!/bin/sh
 
 test_description='basic prepend functionality
 '

tests/t1500-do.sh

@@ -1,4 +1,4 @@
-#!/bin/bash
+#!/bin/sh
 
 test_description='do functionality
 '

tests/t1600-append.sh

@@ -1,4 +1,4 @@
-#!/bin/bash
+#!/bin/sh
 
 test_description='basic append functionality
 

tests/t1700-depri.sh

@@ -1,4 +1,4 @@
-#!/bin/bash
+#!/bin/sh
 
 test_description='basic depriority functionality
 '

tests/t1800-del.sh

@@ -1,4 +1,4 @@
-#!/bin/bash
+#!/bin/sh
 
 test_description='basic del functionality
 '

tests/t1900-archive.sh

@@ -1,4 +1,4 @@
-#!/bin/bash
+#!/bin/sh
 
 test_description='archive functionality
 

tests/t1910-deduplicate.sh

@@ -1,4 +1,4 @@
-#!/bin/bash
+#!/bin/sh
 
 test_description='deduplicate functionality
 

tests/t1950-report.sh

@@ -1,4 +1,4 @@
-#!/bin/bash
+#!/bin/sh
 
 test_description='report functionality
 

tests/t2000-multiline.sh

@@ -1,4 +1,4 @@
-#!/bin/bash
+#!/bin/sh
 
 test_description='Multi-line functionality'
 
@@ -8,18 +8,18 @@ test_description='Multi-line functionality'
 # Create the expected file
 echo "1 smell the cheese
 TODO: Replaced task with:
-1 eat apples eat oranges drink milk">"$HOME/expect.multi"
+1 eat apples eat oranges drink milk">$HOME/expect.multi
 
 test_expect_success 'multiline squash item replace' '
 (
 # Prepare single line todo file
-cat /dev/null > "$HOME/todo.txt"
+cat /dev/null > $HOME/todo.txt
 "$HOME/bin/todo.sh" add smell the cheese
 
 # Run replace
 "$HOME/bin/todo.sh" replace 1 "eat apples
 eat oranges
-drink milk" > "$HOME/output.multi"
+drink milk" > $HOME/output.multi
 
 # Test output against expected
 diff "$HOME/output.multi" "$HOME/expect.multi"
@@ -34,18 +34,18 @@ fi
 ## Add test
 # Create the expected file
 echo "2 eat apples eat oranges drink milk
-TODO: 2 added.">"$HOME/expect.multi"
+TODO: 2 added.">$HOME/expect.multi
 
 test_expect_success 'multiline squash item add' '
 (
 # Prepare single line todo file
-cat /dev/null > "$HOME/todo.txt"
+cat /dev/null > $HOME/todo.txt
 "$HOME/bin/todo.sh" add smell the cheese
 
 # Run add
 "$HOME/bin/todo.sh" add "eat apples
 eat oranges
-drink milk" > "$HOME/output.multi"
+drink milk" > $HOME/output.multi
 
 # Test output against expected
 diff "$HOME/output.multi" "$HOME/expect.multi"
@@ -59,18 +59,18 @@ fi
 
 ## Append test
 # Create the expected file
-echo "1 smell the cheese eat apples eat oranges drink milk">"$HOME/expect.multi"
+echo "1 smell the cheese eat apples eat oranges drink milk">$HOME/expect.multi
 
 test_expect_success 'multiline squash item append' '
 (
 # Prepare single line todo file
-cat /dev/null > "$HOME/todo.txt"
+cat /dev/null > $HOME/todo.txt
 "$HOME/bin/todo.sh" add smell the cheese
 
 # Run append
 "$HOME/bin/todo.sh" append 1 "eat apples
 eat oranges
-drink milk" > "$HOME/output.multi"
+drink milk" > $HOME/output.multi
 
 # Test output against expected
 diff "$HOME/output.multi" "$HOME/expect.multi"
@@ -84,18 +84,18 @@ fi
 
 ## Prepend test
 # Create the expected file
-echo "1 eat apples eat oranges drink milk smell the cheese">"$HOME/expect.multi"
+echo "1 eat apples eat oranges drink milk smell the cheese">$HOME/expect.multi
 
 test_expect_success 'multiline squash item prepend' '
 (
 # Prepare single line todo file
-cat /dev/null > "$HOME/todo.txt"
+cat /dev/null > $HOME/todo.txt
 "$HOME/bin/todo.sh" add smell the cheese
 
 # Run prepend
 "$HOME/bin/todo.sh" prepend 1 "eat apples
 eat oranges
-drink milk" > "$HOME/output.multi"
+drink milk" > $HOME/output.multi
 
 # Test output against expected
 diff "$HOME/output.multi" "$HOME/expect.multi"
@@ -110,18 +110,18 @@ fi
 ## Multiple line addition
 # Create the expected file
 echo "2 eat apples
-TODO: 2 added." > "$HOME/expect.multi"
+TODO: 2 added." > $HOME/expect.multi
 echo "3 eat oranges
-TODO: 3 added." >>"$HOME/expect.multi"
+TODO: 3 added." >>$HOME/expect.multi
 echo "4 drink milk
-TODO: 4 added." >>"$HOME/expect.multi"
+TODO: 4 added." >> $HOME/expect.multi
 
 test_expect_success 'actual multiline add' '
 (
 # Run addm
 "$HOME/bin/todo.sh" addm "eat apples
 eat oranges
-drink milk" > "$HOME/output.multi"
+drink milk" > $HOME/output.multi
 
 # Test output against expected
 diff "$HOME/output.multi" "$HOME/expect.multi"

tests/t2100-help.sh

@@ -1,44 +0,0 @@
-#!/bin/bash
-#
-
-test_description='help functionality
-
-This test covers the help output.
-'
-. ./actions-test-lib.sh
-. ./test-lib.sh
-
-# Note: To avoid having to adapt the test whenever the help documentation
-# slightly changes, only check for the section headers.
-test_todo_session 'help output' <<EOF
->>> todo.sh help | sed '/^  [A-Z]/!d'
-  Usage: todo.sh [-fhpantvV] [-d todo_config] action [task_number] [task_description]
-  Options:
-  Built-in Actions:
-EOF
-
-test_todo_session 'verbose help output' <<EOF
->>> todo.sh -v help | sed '/^  [A-Z]/!d'
-  Usage: todo.sh [-fhpantvV] [-d todo_config] action [task_number] [task_description]
-  Options:
-  Built-in Actions:
-EOF
-
-test_todo_session 'very verbose help output' <<EOF
->>> todo.sh -vv help | sed '/^  [A-Z]/!d'
-  Usage: todo.sh [-fhpantvV] [-d todo_config] action [task_number] [task_description]
-  Options:
-  Environment variables:
-  Built-in Actions:
-EOF
-
-make_action "foo"
-test_todo_session 'help output with custom action' <<EOF
->>> todo.sh -v help | sed '/^  [A-Z]/!d'
-  Usage: todo.sh [-fhpantvV] [-d todo_config] action [task_number] [task_description]
-  Options:
-  Built-in Actions:
-  Add-on Actions:
-EOF
-
-test_done

tests/t2110-help-action.sh

@@ -1,66 +0,0 @@
-#!/bin/bash
-
-test_description='built-in actions help functionality
-
-This test checks listing the usage help of a built-in action.
-'
-. ./test-lib.sh
-
-test_todo_session 'nonexisting action help' <<'EOF'
->>> todo.sh help doesnotexist
-TODO: No action "doesnotexist" exists.
-=== 1
-
->>> todo.sh help hel
-TODO: No action "hel" exists.
-=== 1
-
->>> todo.sh help h
-TODO: No action "h" exists.
-=== 1
-EOF
-
-test_todo_session 'single action help' <<'EOF'
->>> todo.sh help shorthelp
-    shorthelp
-      List the one-line usage of all built-in and add-on actions.
-\
-EOF
-
-test_todo_session 'multiple actions help' <<'EOF'
->>> todo.sh help shorthelp append
-    shorthelp
-      List the one-line usage of all built-in and add-on actions.
-\
-    append ITEM# "TEXT TO APPEND"
-    app ITEM# "TEXT TO APPEND"
-      Adds TEXT TO APPEND to the end of the task on line ITEM#.
-      Quotes optional.
-\
-EOF
-
-test_todo_session 'short and long form of action help' <<'EOF'
->>> todo.sh help append
-    append ITEM# "TEXT TO APPEND"
-    app ITEM# "TEXT TO APPEND"
-      Adds TEXT TO APPEND to the end of the task on line ITEM#.
-      Quotes optional.
-\
-
->>> todo.sh help app
-    app ITEM# "TEXT TO APPEND"
-      Adds TEXT TO APPEND to the end of the task on line ITEM#.
-      Quotes optional.
-\
-EOF
-
-test_todo_session 'mixed existing and nonexisting action help' <<'EOF'
->>> todo.sh help shorthelp doesnotexist list
-    shorthelp
-      List the one-line usage of all built-in and add-on actions.
-\
-TODO: No action "doesnotexist" exists.
-=== 1
-EOF
-
-test_done

tests/t2120-shorthelp.sh

@@ -1,79 +0,0 @@
-#!/bin/bash
-#
-
-test_description='shorthelp functionality
-
-This test covers the output of the -h option and the shorthelp action.
-'
-. ./actions-test-lib.sh
-. ./test-lib.sh
-
-# Note: To avoid having to adapt the test whenever the actions change, only
-# check for the section headers.
-test_todo_session '-h output' <<EOF
->>> todo.sh -h | sed '/^  [A-Z]/!d'
-  Usage: todo.sh [-fhpantvV] [-d todo_config] action [task_number] [task_description]
-  Actions:
-  Actions can be added and overridden using scripts in the actions
-  See "help" for more details.
-EOF
-
-test_todo_session 'shorthelp output' <<EOF
->>> todo.sh shorthelp | sed '/^  [A-Z]/!d'
-  Usage: todo.sh [-fhpantvV] [-d todo_config] action [task_number] [task_description]
-  Actions:
-  Actions can be added and overridden using scripts in the actions
-  See "help" for more details.
-EOF
-
-make_action "foo"
-test_todo_session 'shorthelp output with custom action' <<EOF
->>> todo.sh -v shorthelp | sed '/^  [A-Z]/!d'
-  Usage: todo.sh [-fhpantvV] [-d todo_config] action [task_number] [task_description]
-  Actions:
-  Actions can be added and overridden using scripts in the actions
-  Add-on Actions:
-  See "help" for more details.
-EOF
-
-
-# Verify that custom configuration is actually processed (when the -d option
-# precedes the -h option) by specifying a different actions directory and moving
-# our custom action there. The help output should mention the "Add-On Actions".
-set -o pipefail # So that the sed filter doesn't swallow todo.sh's exit code.
-mv todo.cfg custom.cfg
-mv .todo.actions.d custom.actions
-echo 'export TODO_ACTIONS_DIR=$HOME/custom.actions' >> custom.cfg
-
-test_todo_session '-h and fatal error without config' <<EOF
->>> todo.sh -h | sed '/^ \\{0,2\\}[A-Z]/!d'
-  Usage: todo.sh [-fhpantvV] [-d todo_config] action [task_number] [task_description]
-  Actions:
-  Actions can be added and overridden using scripts in the actions
-  See "help" for more details.
-Fatal Error: Cannot read configuration file $HOME/.todo/config
-=== 1
-EOF
-
-# Config option comes too late; "Add-on Actions" is *not* mentioned here.
-test_todo_session '-h and fatal error with trailing custom config' <<EOF
->>> todo.sh -h -d custom.cfg | sed '/^ \\{0,2\\}[A-Z]/!d'
-  Usage: todo.sh [-fhpantvV] [-d todo_config] action [task_number] [task_description]
-  Actions:
-  Actions can be added and overridden using scripts in the actions
-  See "help" for more details.
-Fatal Error: Cannot read configuration file $HOME/.todo/config
-=== 1
-EOF
-
-# Config option processed; "Add-on Actions" is mentioned here.
-test_todo_session '-h output with preceding custom config' <<EOF
->>> todo.sh -d custom.cfg -h | sed '/^ \\{0,2\\}[A-Z]/!d'
-  Usage: todo.sh [-fhpantvV] [-d todo_config] action [task_number] [task_description]
-  Actions:
-  Actions can be added and overridden using scripts in the actions
-  Add-on Actions:
-  See "help" for more details.
-EOF
-
-test_done

tests/t6000-completion.sh

@@ -1,22 +0,0 @@
-#!/bin/bash
-#
-
-test_description='Bash completion functionality
-
-This test checks basic todo_completion of actions and options
-'
-. ./test-lib.sh
-
-readonly ACTIONS='add a addto addm append app archive command del rm depri dp do help list ls listaddons listall lsa listcon lsc listfile lf listpri lsp listproj lsprj move mv prepend prep pri p replace report shorthelp'
-readonly OPTIONS='-@ -@@ -+ -++ -d -f -h -p -P -PP -a -n -t -v -vv -V -x'
-
-test_todo_completion 'all arguments' 'todo.sh ' "$ACTIONS $OPTIONS"
-test_todo_completion 'arguments beginning with a' 'todo.sh a' 'add a addto addm append app archive'
-test_todo_completion 'all options' 'todo.sh -' "$OPTIONS"
-test_todo_completion 'all actions after command action' 'todo.sh command ' "$ACTIONS"
-test_todo_completion 'all arguments after option' 'todo.sh -a ' "$ACTIONS $OPTIONS"
-test_todo_completion 'all arguments after options' 'todo.sh -a -p ' "$ACTIONS $OPTIONS"
-test_todo_completion 'all options after options' 'todo.sh -a -p -' "$OPTIONS"
-test_todo_completion 'nothing after action' 'todo.sh archive ' ''
-
-test_done

tests/t6010-completion-contexts.sh

@@ -1,27 +0,0 @@
-#!/bin/bash
-#
-
-test_description='Bash context completion functionality
-
-This test checks todo_completion of contexts
-'
-. ./test-lib.sh
-
-cat > todo.txt <<EOF
-(B) smell the +roses @outside @outdoor +shared
-notice the sunflowers +sunflowers @outside @garden +shared +landscape
-stop
-EOF
-cat > done.txt <<EOF
-x 2012-02-21 +herbs @oriental buy spices
-x 2012-02-21 +slack @home watch tv
-EOF
-test_todo_completion 'all contexts' 'todo.sh list @' '@garden @outdoor @outside'
-test_todo_completion 'contexts beginning with o' 'todo.sh list @o' '@outdoor @outside'
-test_todo_completion 'contexts beginning with outs' 'todo.sh list @outs' '@outside'
-test_todo_completion 'contexts beginning with x' 'todo.sh list @x' ''
-
-test_todo_completion 'contexts from done tasks beginning with h' 'todo.sh list @h' '@home'
-test_todo_completion 'contexts from done tasks beginning with or' 'todo.sh list @or' '@oriental'
-
-test_done

tests/t6020-completion-projects.sh

@@ -1,27 +0,0 @@
-#!/bin/bash
-#
-
-test_description='Bash project completion functionality
-
-This test checks todo_completion of projects
-'
-. ./test-lib.sh
-
-cat > todo.txt <<EOF
-(B) smell the +roses @outside @outdoor +shared
-notice the sunflowers +sunflowers @outside @garden +shared +landscape
-stop
-EOF
-cat > done.txt <<EOF
-x 2012-02-21 +herbs @oriental buy spices
-x 2012-02-21 +slack @home watch tv
-EOF
-test_todo_completion 'all projects' 'todo.sh list +' '+landscape +roses +shared +sunflowers'
-test_todo_completion 'projects beginning with s' 'todo.sh list +s' '+shared +sunflowers'
-test_todo_completion 'projects beginning with ro' 'todo.sh list +ro' '+roses'
-test_todo_completion 'projects beginning with x' 'todo.sh list +x' ''
-
-test_todo_completion 'projects from done tasks beginning with h' 'todo.sh list +h' '+herbs'
-test_todo_completion 'projects from done tasks beginning with sl' 'todo.sh list +sl' '+slack'
-
-test_done

tests/t6030-completion-tasks.sh

@@ -1,27 +0,0 @@
-#!/bin/bash
-#
-
-test_description='Bash task number completion functionality
-
-This test checks todo_completion of a task number into the abbreviated task text.
-'
-. ./test-lib.sh
-
-cat > todo.txt <<EOF
-simple task
-notice the sunflowers +sunflowers @outside @garden +shared +landscape
-(B) smell the +roses flower @outside @outdoor +shared
-(C) 2012-02-28 @outside mow the lawn
-x 2012-02-21 +herbs @oriental buy spices
-x 2012-02-28 2012-02-21 +slack @home watch tv
-2012-02-28 +herbs buy cinnamon @grocer
-EOF
-test_todo_completion 'simple task' 'todo.sh list 1' '"1 # simple task"'
-test_todo_completion 'remove projects and contents from task' 'todo.sh list 2' '"2 # notice the sunflowers"'
-test_todo_completion 'keep priority' 'todo.sh list 3' '"3 # (B) smell the flower"'
-test_todo_completion 'keep priority and remove timestamp' 'todo.sh list 4' '"4 # (C) mow the lawn"'
-test_todo_completion 'keep done marker and remove done date' 'todo.sh list 5' '"5 # x buy spices"'
-test_todo_completion 'keep done marker and remove timestamp and done date' 'todo.sh list 6' '"6 # x watch tv"'
-test_todo_completion 'remove add date' 'todo.sh list 7' '"7 # buy cinnamon"'
-
-test_done

tests/t6040-completion-files.sh

@@ -1,21 +0,0 @@
-#!/bin/bash
-#
-
-test_description='Bash todo file completion functionality
-
-This test checks todo_completion of files in TODO_DIR.
-'
-. ./test-lib.sh
-
-> dummy.txt
-readonly FILES='done.txt dummy.txt report.txt todo.txt'
-test_todo_completion 'all files after addto' 'todo.sh addto ' "$FILES"
-test_todo_completion 'files beginning with d after addto' 'todo.sh addto d' 'done.txt dummy.txt'
-test_todo_completion 'all files after listfile' 'todo.sh listfile ' "$FILES"
-test_todo_completion 'all files after lf' 'todo.sh -v lf ' "$FILES"
-test_todo_completion 'nothing after move' 'todo.sh move ' ''
-test_todo_completion 'all files after move ITEM#' 'todo.sh move 1 ' "$FILES"
-test_todo_completion 'all files after mv ITEM#' 'todo.sh mv 1 ' "$FILES"
-test_todo_completion 'all files after move ITEM# DEST' 'todo.sh move 1 todo.sh ' "$FILES"
-
-test_done

tests/t6050-completion-addons.sh

@@ -1,74 +0,0 @@
-#!/bin/bash
-#
-
-test_description='Bash add-on action completion functionality
-
-This test checks todo_completion of custom actions in .todo.actions.d
-'
-. ./test-lib.sh
-
-readonly ACTIONS='add a addto addm append app archive command del rm depri dp do help list ls listaddons listall lsa listcon lsc listfile lf listpri lsp listproj lsprj move mv prepend prep pri p replace report shorthelp'
-readonly OPTIONS='-@ -@@ -+ -++ -d -f -h -p -P -PP -a -n -t -v -vv -V -x'
-
-readonly ADDONS='bar baz foobar'
-makeCustomActions()
-{
-    set -e
-    mkdir "${1:?}"
-    for addon in $ADDONS
-    do
-        addonFile="${1}/$addon"
-        > "$addonFile"
-        chmod +x "$addonFile"
-    done
-
-    # Also create a subdirectory, to test that it is skipped.
-    mkdir "${1}/subdir"
-
-    # Also create a non-executable file, to test that it is skipped.
-    datafile="${1:?}/datafile"
-    > "$datafile"
-    chmod -x "$datafile"
-    [ -x "$datafile" ] && rm "$datafile"    # Some file systems may always make files executable; then, skip this check.
-
-    set +e
-}
-removeCustomActions()
-{
-    set -e
-    rmdir "${1}/subdir"
-    rm "${1:?}/"*
-    rmdir "$1"
-    set +e
-}
-
-#
-# Test resolution of the default TODO_ACTIONS_DIR.
-#
-makeCustomActions "$HOME/.todo.actions.d"
-test_todo_completion 'all arguments' 'todo.sh ' "$ACTIONS $ADDONS $OPTIONS"
-test_todo_completion 'all arguments after option' 'todo.sh -a ' "$ACTIONS $ADDONS $OPTIONS"
-test_todo_completion 'all arguments beginning with b' 'todo.sh b' 'bar baz'
-test_todo_completion 'all arguments beginning with f after options' 'todo.sh -a -v f' 'foobar'
-test_todo_completion 'nothing after addon action' 'todo.sh foobar ' ''
-removeCustomActions "$HOME/.todo.actions.d"
-
-#
-# Test resolution of an alternative TODO_ACTIONS_DIR.
-#
-mkdir  "$HOME/.todo"
-makeCustomActions "$HOME/.todo/actions"
-test_todo_completion 'all arguments with actions from .todo/actions/' 'todo.sh ' "$ACTIONS $ADDONS $OPTIONS"
-removeCustomActions "$HOME/.todo/actions"
-
-#
-# Test resolution of a configured TODO_ACTIONS_DIR.
-#
-makeCustomActions "$HOME/addons"
-cat >> todo.cfg <<'EOF'
-export TODO_ACTIONS_DIR="$HOME/addons"
-EOF
-test_todo_completion 'all arguments with actions from addons/' 'todo.sh ' "$ACTIONS $ADDONS $OPTIONS"
-removeCustomActions "$HOME/addons"
-
-test_done

tests/t6080-completion-path.sh

@@ -1,45 +0,0 @@
-#!/bin/bash
-#
-
-test_description='Bash completion with different path functionality
-
-This test checks that todo_completion can use a different path to todo.sh when
-it is not accessible through PATH.
-'
-. ./test-lib.sh
-
-cat > todo.txt <<EOF
-(B) smell the +roses @outside @outdoor +shared
-notice the sunflowers +sunflowers @outside @garden +shared +landscape
-stop
-EOF
-
-mv bin/todo.sh bin/todo2.sh
-test_expect_success 'todo2.sh executable' 'todo2.sh list'
-
-# Define a second completion function that injects the different executable. In
-# real use, this would be installed via
-#   complete -F _todo2 todo2.sh
-_todo2()
-{
-    local _todo_sh='todo2.sh'
-    _todo "$@"
-}
-
-test_todo_custom_completion _todo2 'all todo2 contexts' 'todo2 list @' '@garden @outdoor @outside'
-
-
-
-# Remove the test environment's bin directory from the PATH, so that our test
-# executable must be launched with an explicit path.
-PATH=${PATH##"${PWD}/bin:"}
-test_expect_code 127 'todo2.sh executable not in PATH' 'todo2.sh'
-
-_todo2path()
-{
-    local _todo_sh='./bin/todo2.sh'
-    _todo "$@"
-}
-test_todo_custom_completion _todo2path 'all todo2 contexts' 'todo2 list @' '@garden @outdoor @outside'
-
-test_done

tests/t6090-completion-aliases.sh

@@ -1,62 +0,0 @@
-#!/bin/bash
-#
-
-test_description='Bash completion with different aliases functionality
-
-This test checks that todo_completion can use a different configuration
-when another todo.sh alias is defined that uses that configuration.
-'
-. ./test-lib.sh
-
-cat > todo.txt <<EOF
-(B) smell the +roses @outside @outdoor +shared
-notice the sunflowers +sunflowers @outside @garden +shared +landscape
-stop
-EOF
-cat > todo2.txt <<EOF
-+herbs @oriental buy spices
-+slack @home watch tv
-EOF
-
-cp todo.cfg todo2.cfg
-cat >> todo2.cfg <<'EOF'
-export TODO_FILE="$TODO_DIR/todo2.txt"
-EOF
-
-# Note: We cannot use aliases within the test framework, but functions are
-# equivalent and work fine.
-todo1()
-{
-    todo.sh "$@"
-}
-todo2()
-{
-    todo.sh -d "$HOME/todo2.cfg" "$@"
-}
-
-# Ensure that the test fixture works as planned.
-test_todo_session 'todo 1 and 2 contexts' <<EOF
->>> todo1 listcon
-@garden
-@outdoor
-@outside
-
->>> todo2 listcon
-@home
-@oriental
-EOF
-
-
-# Define a second completion function that injects the different configuration
-# file. In real use, this would be installed via
-#   complete -F _todo2 todo2
-_todo2()
-{
-    local _todo_sh='todo.sh -d "$HOME/todo2.cfg"'
-    _todo "$@"
-}
-
-test_todo_completion               'all todo1 contexts' 'todo1 list @' '@garden @outdoor @outside'
-test_todo_custom_completion _todo2 'all todo2 contexts' 'todo2 list @' '@home @oriental'
-
-test_done

tests/t6100-completion-help.sh

@@ -1,20 +0,0 @@
-#!/bin/bash
-#
-
-test_description='Bash help completion functionality
-
-This test checks todo_completion of actions for usage help.
-'
-. ./actions-test-lib.sh
-. ./test-lib.sh
-make_action "zany"
-make_action "aardvark"
-
-readonly ACTIONS='add a addto addm append app archive command del rm depri dp do help list ls listaddons listall lsa listcon lsc listfile lf listpri lsp listproj lsprj move mv prepend prep pri p replace report shorthelp'
-readonly ADDONS='aardvark zany'
-
-test_todo_completion 'all actions after help' 'todo.sh help ' "$ACTIONS $ADDONS"
-test_todo_completion 'all actions after command help' 'todo.sh command help ' "$ACTIONS $ADDONS"
-test_todo_completion 'actions beginning with a' 'todo.sh help a' 'add a addto addm append app archive aardvark'
-
-test_done

tests/t8000-actions.sh

@@ -1,12 +1,22 @@
-#!/bin/bash
+#!/bin/sh
 
 test_description='custom actions functionality
 
 This test covers the contract between todo.sh and custom actions.
 '
-. ./actions-test-lib.sh
 . ./test-lib.sh
 
+unset TODO_ACTIONS_DIR
+mkdir .todo.actions.d
+make_action()
+{
+	cat > ".todo.actions.d/$1" <<- EOF
+	#!/bin/bash
+	echo "custom action $1"
+EOF
+chmod +x ".todo.actions.d/$1"
+}
+
 make_action "foo"
 test_todo_session 'executable action' <<EOF
 >>> todo.sh foo

tests/t8010-listaddons.sh

@@ -1,44 +0,0 @@
-#!/bin/bash
-
-test_description='listaddons functionality
-
-This test checks listing of custom actions.
-'
-. ./actions-test-lib.sh
-. ./test-lib.sh
-
-test_todo_session 'no custom actions' <<EOF
->>> todo.sh listaddons
-EOF
-
-make_action "foo"
-test_todo_session 'one custom action' <<EOF
->>> todo.sh listaddons
-foo
-EOF
-
-make_action "bar"
-make_action "ls"
-make_action "quux"
-test_todo_session 'multiple custom actions' <<EOF
->>> todo.sh listaddons
-bar
-foo
-ls
-quux
-EOF
-
-chmod -x .todo.actions.d/foo
-# On Cygwin, clearing the executable flag may have no effect, as the Windows ACL
-# may still grant execution rights. In this case, we skip the test.
-if [ -x .todo.actions.d/foo ]; then
-    SKIP_TESTS="${SKIP_TESTS}${SKIP_TESTS+ }t8010.4"
-fi
-test_todo_session 'nonexecutable action' <<EOF
->>> todo.sh listaddons
-bar
-ls
-quux
-EOF
-
-test_done

tests/t8020-actions-help.sh

@@ -1,76 +0,0 @@
-#!/bin/bash
-
-test_description='custom actions help functionality
-
-This test checks listing the usage help of a custom action.
-'
-. ./actions-test-lib.sh
-. ./test-lib.sh
-
-test_todo_session 'custom action help with no custom action directory' <<'EOF'
->>> todo.sh help foo
-TODO: No action "foo" exists.
-=== 1
-EOF
-
-make_action "foo"
-make_action "bar"
-make_action "ls"
-make_action "quux"
-
-test_todo_session 'custom action help' <<'EOF'
->>> todo.sh help foo
-    foo ITEM#[, ITEM#, ...] [TERM...]
-      This custom action does foo.
-\
-
->>> todo.sh help bar
-    bar ITEM#[, ITEM#, ...] [TERM...]
-      This custom action does bar.
-\
-EOF
-
-test_todo_session 'multiple custom actions help' <<'EOF'
->>> todo.sh help foo bar
-    foo ITEM#[, ITEM#, ...] [TERM...]
-      This custom action does foo.
-\
-    bar ITEM#[, ITEM#, ...] [TERM...]
-      This custom action does bar.
-\
-EOF
-
-test_todo_session 'nonexisting action help' <<'EOF'
->>> todo.sh help doesnotexist
-TODO: No action "doesnotexist" exists.
-=== 1
-
->>> todo.sh help foo doesnotexist bar
-    foo ITEM#[, ITEM#, ...] [TERM...]
-      This custom action does foo.
-\
-TODO: No action "doesnotexist" exists.
-=== 1
-EOF
-
-test_todo_session 'mixed built-in and custom actions help' <<'EOF'
->>> todo.sh help foo shorthelp bar
-    foo ITEM#[, ITEM#, ...] [TERM...]
-      This custom action does foo.
-\
-    shorthelp
-      List the one-line usage of all built-in and add-on actions.
-\
-    bar ITEM#[, ITEM#, ...] [TERM...]
-      This custom action does bar.
-\
-EOF
-
-test_todo_session 'custom override of built-in action help' <<'EOF'
->>> todo.sh help ls
-    ls ITEM#[, ITEM#, ...] [TERM...]
-      This custom action does ls.
-\
-EOF
-
-test_done

tests/t9999-testsuite_example.sh

@@ -1,4 +1,4 @@
-#!/bin/bash
+#!/bin/sh
 
 test_description='basic tests imported from previous framework
 '

tests/test-lib.sh

@@ -1,4 +1,4 @@
-#!/bin/bash
+#!/bin/sh
 #
 # Copyright (c) 2005 Junio C Hamano
 #
@@ -264,7 +264,25 @@ test_expect_success () {
 test_expect_output () {
 	test "$#" = 2 ||
 	error "bug in the test script: not 2 parameters to test-expect-output"
-	test_expect_code_and_output 0 "$@"
+	if ! test_skip "$@"
+	then
+		say >&3 "expecting success and output: $2"
+		test_run_ "$2"
+		if [ "$?" = 0 -a "$eval_ret" = 0 ]
+		then
+			cmp_output=$(test_cmp expect output)
+			if [ "$?" = 0 ]
+			then
+				test_ok_ "$1"
+			else
+				test_failure_ "$@" "
+$cmp_output"
+			fi
+		else
+			test_failure_ "$@"
+		fi
+	fi
+	echo >&3 ""
 }
 
 test_expect_code_and_output () {
@@ -272,11 +290,7 @@ test_expect_code_and_output () {
 	error "bug in the test script: not 3 parameters to test-expect-code-and-output"
 	if ! test_skip "$@"
 	then
-		if [ "$1" = 0 ]; then
-			say >&3 "expecting success and output: $3"
-		else
 		say >&3 "expecting exit code $1 and output: $3"
-		fi
 		test_run_ "$3"
 		if [ "$?" = 0 -a "$eval_ret" = "$1" ]
 		then
@@ -291,7 +305,7 @@ $cmp_output"
 		else
 			cmp_output=$(test_cmp expect output)
 			test_failure_ "$2" "$3" "
-expected exit code $1, actual ${eval_ret}${cmp_output:+
+* expected exit code $1, actual ${eval_ret}${cmp_output:+
 }${cmp_output}"
 		fi
 	fi
@@ -310,7 +324,7 @@ test_expect_code () {
 			test_ok_ "$2"
 		else
 			test_failure_ "$2" "$3" "
-expected exit code $1, actual ${eval_ret}"
+* expected exit code $1, actual ${eval_ret}"
 		fi
 	fi
 	echo >&3 ""
@@ -552,16 +566,14 @@ test_tick () {
 }
 
 # Generate and run a series of tests based on a transcript.
-# Usage: test_todo_session "description" <<'EOF'
+# Usage: test_todo_session "description" <<EOF
 # >>> command
 # output1
 # output2
-#
 # >>> command
 # === exit status
-# output3 with empty line (must be escaped here)
+# output3
-# \
+# output4
-# output5
 # EOF
 test_todo_session () {
     test "$#" = 1 ||
@@ -570,7 +582,7 @@ test_todo_session () {
     cmd=""
     status=0
     > expect
-    while IFS= read -r line
+    while read -r line
     do
 	case $line in
 	">>> "*)
@@ -594,9 +606,6 @@ test_todo_session () {
 		> expect
 	    fi
 	    ;;
-	\\)
-	    echo "" >> expect
-	    ;;
 	*)
 	    echo "$line" >> expect
 	    ;;
@@ -623,66 +632,6 @@ EOF
 	exit 0
 }
 
-test_todo_custom_completion () {
-	test "$#" = 4 ||
-	error "bug in the test script: not 4 parameters to test_todo_custom_completion"
-	completeFunc=$1
-	shift
-	if ! test_skip "$@"
-	then
-		description=$1
-		expected=$3
-
-		if [ "${2: -1}" = ' ' ]
-		then
-			offset=0
-			say >&3 "expecting completions after: '$2'"
-		else
-			offset=1
-			say >&3 "expecting context completions for: '$2'"
-		fi
-
-		SAVEIFS=$IFS
-		IFS=' ' set -- $2
-		COMP_WORDS=("$@")
-		COMP_CWORD=$(($# - $offset))
-		IFS=' ' eval "set -- $expected"
-		EXPECT=("$@")
-
-		source "$TEST_DIRECTORY/../todo_completion"
-		$completeFunc
-		ret=$?
-		if [ "$ret" = 0 ]
-		then
-			IFS=$'\n'
-			printf "%s${EXPECT:+\\n}" "${EXPECT[*]}" > expect
-			printf "%s${COMPREPLY:+\\n}" "${COMPREPLY[*]}" > compreply
-			IFS=$SAVEIFS
-
-			if [ ${#COMPREPLY[@]} -eq ${#EXPECT[@]} ]
-			then
-				if [ "${COMPREPLY[*]}" = "${EXPECT[*]}" ]
-				then
-					test_ok_ "$description"
-				else
-					test_failure_ "$description" "$(test_cmp expect compreply)"
-				fi
-			else
-				test_failure_ "$description" "expected ${#EXPECT[@]} completion(s), got ${#COMPREPLY[@]}:
-$(test_cmp expect compreply)"
-			fi
-		else
-			test_failure_ "$description" "expected completions, actual exit code $ret"
-		fi
-	fi
-	echo >&3 ""
-}
-test_todo_completion () {
-	test "$#" = 3 ||
-	error "bug in the test script: not 3 parameters to test_todo_completion"
-	test_todo_custom_completion _todo "$@"
-}
-
 test_init_todo "$test"
 # Use -P to resolve symlinks in our working directory so that the pwd
 # in subprocesses equals our $PWD (for pathname comparisons).

tests/testshell.sh

@@ -1,4 +1,4 @@
-#!/bin/bash
+#!/bin/sh
 
 test_description='Providing an interactive shell in the proper environment'
 . ./test-lib.sh

todo.cfg

@@ -2,7 +2,7 @@
 
 # Your todo.txt directory
 #export TODO_DIR="/Users/gina/Documents/todo"
-export TODO_DIR=$(dirname "$0")
+export TODO_DIR=`dirname "$0"`
 
 # Your todo/done/report.txt locations
 export TODO_FILE="$TODO_DIR/todo.txt"

todo.sh

@@ -54,11 +54,10 @@ shorthelp()
 		    del|rm ITEM# [TERM]
 		    depri|dp ITEM#[, ITEM#, ITEM#, ...]
 		    do ITEM#[, ITEM#, ITEM#, ...]
-		    help [ACTION...]
+		    help
 		    list|ls [TERM...]
 		    listall|lsa [TERM...]
-		    listaddons
+		    listcon|lsc
-		    listcon|lsc [TERM...]
 		    listfile|lf [SRC [TERM...]]
 		    listpri|lsp [PRIORITIES] [TERM...]
 		    listproj|lsprj [TERM...]
@@ -81,6 +80,7 @@ shorthelp()
 
 		  See "help" for more details.
 	EndHelpFooter
+    exit 0
 }
 
 help()
@@ -136,7 +136,7 @@ help()
 
 	EndOptionsHelp
 
-    [ $TODOTXT_VERBOSE -gt 1 ] && cat <<-'EndVerboseHelp'
+    [ $TODOTXT_VERBOSE -gt 1 ] && cat <<-EndVerboseHelp
 		  Environment variables:
 		    TODOTXT_AUTO_ARCHIVE            is same as option -a (0)/-A (1)
 		    TODOTXT_CFG_FILE=CONFIG_FILE    is same as option -d CONFIG_FILE
@@ -149,16 +149,9 @@ help()
 		    TODOTXT_DEFAULT_ACTION=""       run this when called with no arguments
 		    TODOTXT_SORT_COMMAND="sort ..." customize list output
 		    TODOTXT_FINAL_FILTER="sed ..."  customize list after color, P@+ hiding
-		    TODOTXT_SOURCEVAR=\$DONE_FILE   use another source for listcon, listproj
 
 
 	EndVerboseHelp
-        actionsHelp
-        addonHelp
-}
-
-actionsHelp()
-{
     cat <<-EndActionsHelp
 		  Built-in Actions:
 		    add "THING I NEED TO DO +project @context"
@@ -205,9 +198,8 @@ actionsHelp()
 		    do ITEM#[, ITEM#, ITEM#, ...]
 		      Marks task(s) on line ITEM# as done in todo.txt.
 
-		    help [ACTION...]
+		    help
-		      Display help about usage, options, built-in and add-on actions,
+		      Display this help message.
-		      or just the usage help for the passed ACTION(s).
 
 		    list [TERM...]
 		    ls [TERM...]
@@ -226,13 +218,9 @@ actionsHelp()
 		      TERM specified, lists entire todo.txt AND done.txt
 		      concatenated and sorted.
 
-		    listaddons
+		    listcon
-		      Lists all added and overridden actions in the actions directory.
+		    lsc
-
-		    listcon [TERM...]
-		    lsc [TERM...]
 		      Lists all the task contexts that start with the @ sign in todo.txt.
-		      If TERM specified, considers only tasks that contain TERM(s).
 
 		    listfile [SRC [TERM...]]
 		    lf [SRC [TERM...]]
@@ -252,11 +240,10 @@ actionsHelp()
 		      Hides all tasks that contain TERM(s) preceded by a minus sign
 		      (i.e. -TERM).  
 
-		    listproj [TERM...]
+		    listproj
-		    lsprj [TERM...]
+		    lsprj
 		      Lists all the projects (terms that start with a + sign) in
 		      todo.txt.
-		      If TERM specified, considers only tasks that contain TERM(s).
 
 		    move ITEM# DEST [SRC]
 		    mv ITEM# DEST [SRC]
@@ -286,6 +273,9 @@ actionsHelp()
 		      List the one-line usage of all built-in and add-on actions.
 
 	EndActionsHelp
+
+        addonHelp
+    exit 1
 }
 
 addonHelp()
@@ -307,35 +297,6 @@ addonHelp()
     fi
 }
 
-actionUsage()
-{
-    for actionName
-    do
-        action="${TODO_ACTIONS_DIR}/${actionName}"
-        if [ -f "$action" -a -x "$action" ]; then
-            "$action" usage
-        else
-            builtinActionUsage=$(actionsHelp | sed -n -e "/^    ${actionName//\//\\/} /,/^\$/p" -e "/^    ${actionName//\//\\/}$/,/^\$/p")
-            if [ "$builtinActionUsage" ]; then
-                echo "$builtinActionUsage"
-                echo
-            else
-                die "TODO: No action \"${actionName}\" exists."
-            fi
-        fi
-    done
-}
-
-dieWithHelp()
-{
-    case "$1" in
-        help)       help;;
-        shorthelp)  shorthelp;;
-    esac
-    shift
-
-    die "$@"
-}
 die()
 {
     echo "$*"
@@ -423,22 +384,21 @@ replaceOrPrepend()
   else
     input=$*
   fi
+  cleaninput "for sed"
 
   # Retrieve existing priority and prepended date
-  local -r priAndDateExpr='^\((.) \)\{0,1\}\([0-9]\{2,4\}-[0-9]\{2\}-[0-9]\{2\} \)\{0,1\}'
+  priority=$(sed -e "$item!d" -e $item's/^\((.) \)\{0,1\}\([0-9]\{2,4\}-[0-9]\{2\}-[0-9]\{2\} \)\{0,1\}.*/\1/' "$TODO_FILE")
-  priority=$(sed -e "$item!d" -e "${item}s/${priAndDateExpr}.*/\\1/" "$TODO_FILE")
+  prepdate=$(sed -e "$item!d" -e $item's/^\((.) \)\{0,1\}\([0-9]\{2,4\}-[0-9]\{2\}-[0-9]\{2\} \)\{0,1\}.*/\2/' "$TODO_FILE")
-  prepdate=$(sed -e "$item!d" -e "${item}s/${priAndDateExpr}.*/\\2/" "$TODO_FILE")
 
-  if [ "$prepdate" -a "$action" = "replace" ] && [ "$(echo "$input"|sed -e "s/${priAndDateExpr}.*/\\1\\2/")" ]; then
+  if [ "$prepdate" -a "$action" = "replace" ] && [ "$(echo "$input"|sed -e 's/^\([0-9]\{2,4\}-[0-9]\{2\}-[0-9]\{2\}\)\{0,1\}.*/\1/')" ]; then
-      # If the replaced text starts with a [priority +] date, it will replace
+    # If the replaced text starts with a date, it will replace the existing
-      # the existing date, too.
+    # date, too.
     prepdate=
   fi
 
   # Temporarily remove any existing priority and prepended date, perform the
   # change (replace/prepend) and re-insert the existing priority and prepended
   # date again.
-  cleaninput "for sed"
   sed -i.bak -e "$item s/^${priority}${prepdate}//" -e "$item s|^.*|${priority}${prepdate}${input}${backref}|" "$TODO_FILE"
   if [ $TODOTXT_VERBOSE -gt 0 ]; then
     getNewtodo "$item"
@@ -523,7 +483,6 @@ do
         # Cannot just invoke shorthelp() because we need the configuration
         # processed to locate the add-on actions directory.
         set -- '-h' 'shorthelp'
-        OPTIND=2
         ;;
     n )
         OVR_TODOTXT_PRESERVE_LINE_NUMBERS=0
@@ -664,7 +623,7 @@ fi
 }
 
 # === SANITY CHECKS (thanks Karl!) ===
-[ -r "$TODOTXT_CFG_FILE" ] || dieWithHelp "$1" "Fatal Error: Cannot read configuration file $TODOTXT_CFG_FILE"
+[ -r "$TODOTXT_CFG_FILE" ] || die "Fatal Error: Cannot read configuration file $TODOTXT_CFG_FILE"
 
 . "$TODOTXT_CFG_FILE"
 
@@ -703,8 +662,8 @@ fi
 ACTION=${1:-$TODOTXT_DEFAULT_ACTION}
 
 [ -z "$ACTION" ]    && usage
-[ -d "$TODO_DIR" ]  || dieWithHelp "$1" "Fatal Error: $TODO_DIR is not a directory"
+[ -d "$TODO_DIR" ]  || die "Fatal Error: $TODO_DIR is not a directory"
-( cd "$TODO_DIR" )  || dieWithHelp "$1" "Fatal Error: Unable to cd to $TODO_DIR"
+( cd "$TODO_DIR" )  || die "Fatal Error: Unable to cd to $TODO_DIR"
 
 [ -f "$TODO_FILE" ] || cp /dev/null "$TODO_FILE"
 [ -f "$DONE_FILE" ] || cp /dev/null "$DONE_FILE"
@@ -867,7 +826,7 @@ _format()
             {
                 if (match($0, /^[0-9]+ x /)) {
                     print highlight("COLOR_DONE") $0 highlight("DEFAULT")
-                } else if (match($0, /^[0-9]+ \([A-Z]\) /)) {
+                } else if (match($0, /^[0-9]+ \([A-Z]\)[[:space:]]/)) {
                     clr = highlight("PRI_" substr($0, RSTART + RLENGTH - 3, 1))
                     print \
                         (clr ? clr : highlight("PRI_X")) \
@@ -894,17 +853,7 @@ _format()
     fi
 }
 
-listWordsWithSigil()
+export -f cleaninput getPrefix getTodo getNewtodo shellquote filtercommand _list getPadding _format die
-{
-    sigil=$1
-    shift
-
-    FILE=$TODO_FILE
-    [ "$TODOTXT_SOURCEVAR" ] && eval "FILE=$TODOTXT_SOURCEVAR"
-    eval "$(filtercommand 'cat "${FILE[@]}"' '' "$@")" | grep -o "[^ ]*${sigil}[^ ]\\+" | grep "^$sigil" | sort -u
-}
-
-export -f cleaninput getPrefix getTodo getNewtodo shellquote filtercommand _list listWordsWithSigil getPadding _format die
 
 # == HANDLE ACTION ==
 action=$( printf "%s\n" "$ACTION" | tr 'A-Z' 'a-z' )
@@ -1121,11 +1070,6 @@ case $action in
     ;;
 
 "help" )
-    shift  ## Was help; new $1 is first help topic / action name
-    if [ $# -gt 0 ]; then
-        # Don't use PAGER here; we don't expect much usage output from one / few actions.
-        actionUsage "$@"
-    else
     if [ -t 1 ] ; then # STDOUT is a TTY
         if which "${PAGER:-less}" >/dev/null 2>&1; then
             # we have a working PAGER (or less as a default)
@@ -1133,7 +1077,6 @@ case $action in
         fi
     fi
     help # just in case something failed above, we go ahead and just spew to STDOUT
-    fi
     ;;
 
 "shorthelp" )
@@ -1157,7 +1100,7 @@ case $action in
     TOTAL=$( sed -n '$ =' "$TODO_FILE" )
     PADDING=${#TOTAL}
 
-    post_filter_command="${post_filter_command:-}${post_filter_command:+ | }awk -v TOTAL=$TOTAL -v PADDING=$PADDING '{ \$1 = sprintf(\"%\" PADDING \"d\", (\$1 > TOTAL ? 0 : \$1)); print }' "
+    post_filter_command="awk -v TOTAL=$TOTAL -v PADDING=$PADDING '{ \$1 = sprintf(\"%\" PADDING \"d\", (\$1 > TOTAL ? 0 : \$1)); print }' "
     cat "$TODO_FILE" "$DONE_FILE" | TODOTXT_VERBOSE=0 _format '' "$PADDING" "$@"
 
     if [ $TODOTXT_VERBOSE -gt 0 ]; then
@@ -1185,20 +1128,19 @@ case $action in
     ;;
 
 "listcon" | "lsc" )
-    shift
+    grep -o '[^ ]*@[^ ]\+' "$TODO_FILE" | grep '^@' | sort -u
-    listWordsWithSigil '@' "$@"
     ;;
 
 "listproj" | "lsprj" )
     shift
-    listWordsWithSigil '+' "$@"
+    eval "$(filtercommand 'cat "$TODO_FILE"' '' "$@")" | grep -o '[^ ]*+[^ ]\+' | grep '^+' | sort -u
     ;;
 
 "listpri" | "lsp" )
     shift ## was "listpri", new $1 is priority to list or first TERM
 
     pri=$(printf "%s\n" "$1" | tr 'a-z' 'A-Z' | grep -e '^[A-Z]$' -e '^[A-Z]-[A-Z]$') && shift || pri="A-Z"
-    post_filter_command="${post_filter_command:-}${post_filter_command:+ | }grep '^ *[0-9]\+ ([${pri}]) '"
+    post_filter_command="grep '^ *[0-9]\+ ([${pri}]) '"
     _list "$TODO_FILE" "$@"
     ;;
 
@@ -1353,18 +1295,6 @@ note: PRIORITY must be anywhere from A to Z."
     fi
     ;;
 
-"listaddons" )
-    if [ -d "$TODO_ACTIONS_DIR" ]; then
-        cd "$TODO_ACTIONS_DIR" || exit $?
-        for action in *
-        do
-            if [ -f "$action" -a -x "$action" ]; then
-                echo "$action"
-            fi
-        done
-    fi
-    ;;
-
 * )
     usage;;
 esac

todo_completion

@@ -11,42 +11,32 @@ _todo()
     local -r OPTS="-@ -@@ -+ -++ -d -f -h -p -P -PP -a -n -t -v -vv -V -x"
     local -r COMMANDS="\
         add a addto addm append app archive command del  \
-        rm depri dp do help list ls listaddons listall lsa listcon  \
+        rm depri dp do help list ls listall lsa listcon  \
         lsc listfile lf listpri lsp listproj lsprj move \
         mv prepend prep pri p replace report shorthelp"
-    local -r MOVE_COMMAND_PATTERN='^(move|mv)$'
 
-    local _todo_sh=${_todo_sh:-todo.sh}
+    # Add custom commands from add-ons, if installed.
+    # TODO: Filter for executable flag of files found in $TODO_ACTIONS_DIR.
+    local allCommands="$COMMANDS $('ls' "${TODO_ACTIONS_DIR:-$HOME/.todo.actions.d}/" 2>/dev/null)"
+
     local completions
     if [ $COMP_CWORD -eq 1 ]; then
-        completions="$COMMANDS $(eval TODOTXT_VERBOSE=0 $_todo_sh command listaddons) $OPTS"
+        completions="$allCommands $OPTS"
     elif [[ $COMP_CWORD -gt 2 && ( \
-        "${COMP_WORDS[COMP_CWORD-2]}" =~ $MOVE_COMMAND_PATTERN || \
+        "${COMP_WORDS[COMP_CWORD-2]}" =~ ^(move|mv)$ || \
-        "${COMP_WORDS[COMP_CWORD-3]}" =~ $MOVE_COMMAND_PATTERN ) ]]; then
+        "${COMP_WORDS[COMP_CWORD-3]}" =~ ^(move|mv)$ ) ]]; then
         # "move ITEM# DEST [SRC]" has file arguments on positions 2 and 3.
-        completions=$(eval TODOTXT_VERBOSE=0 $_todo_sh command listfile)
+        completions=$(TODOTXT_VERBOSE=0 todo.sh command listfile)
     else
         case "$prev" in
             command)
                 completions=$COMMANDS;;
-            help)
-                completions="$COMMANDS $(eval TODOTXT_VERBOSE=0 $_todo_sh command listaddons)";;
             addto|listfile|lf)
-                completions=$(eval TODOTXT_VERBOSE=0 $_todo_sh command listfile);;
+                completions=$(TODOTXT_VERBOSE=0 todo.sh command listfile);;
-            -*) completions="$COMMANDS $(eval TODOTXT_VERBOSE=0 $_todo_sh command listaddons) $OPTS";;
+            -*) completions="$allCommands $OPTS";;
             *)  case "$cur" in
-                    +*) completions=$(eval TODOTXT_VERBOSE=0 $_todo_sh command listproj)
+                    +*) completions=$(TODOTXT_VERBOSE=0 todo.sh command listproj);;
-                        COMPREPLY=( $( compgen -W "$completions" -- $cur ))
+                    @*) completions=$(TODOTXT_VERBOSE=0 todo.sh command listcon);;
-                        [ ${#COMPREPLY[@]} -gt 0 ] && return 0
-                        # Fall back to projects extracted from done tasks.
-                        completions=$(eval 'TODOTXT_VERBOSE=0 TODOTXT_SOURCEVAR=\$DONE_FILE' $_todo_sh command listproj)
-                        ;;
-                    @*) completions=$(eval TODOTXT_VERBOSE=0 $_todo_sh command listcon)
-                        COMPREPLY=( $( compgen -W "$completions" -- $cur ))
-                        [ ${#COMPREPLY[@]} -gt 0 ] && return 0
-                        # Fall back to contexts extracted from done tasks.
-                        completions=$(eval 'TODOTXT_VERBOSE=0 TODOTXT_SOURCEVAR=\$DONE_FILE' $_todo_sh command listcon)
-                        ;;
                     *)  if [[ "$cur" =~ ^[0-9]+$ ]]; then
                             # Remove the (padded) task number; we prepend the
                             # user-provided $cur instead.
@@ -60,9 +50,9 @@ _todo()
                             # Finally, limit the output to a single line just as
                             # a safety check of the ls action output.
                             local todo=$( \
-                                eval TODOTXT_VERBOSE=0 $_todo_sh '-@ -+ -p -x command ls "^ *${cur} "' | \
+                                TODOTXT_VERBOSE=0 todo.sh -@ -+ -p -x command ls "^ *${cur} " | \
-                                sed -e 's/^ *[0-9]\{1,\} //' -e 's/^\((.) \)\{0,1\}[0-9]\{2,4\}-[0-9]\{2\}-[0-9]\{2\} /\1/' \
+                                sed -e 's/^ *[0-9]\+ //' -e 's/\((.) \)[0-9]\{2,4\}-[0-9]\{2\}-[0-9]\{2\} /\1/' \
-                                    -e 's/^\([xX] \)\([0-9]\{2,4\}-[0-9]\{2\}-[0-9]\{2\} \)\{1,2\}/\1/' \
+                                    -e 's/\([xX] \)\([0-9]\{2,4\}-[0-9]\{2\}-[0-9]\{2\} \)\{1,2\}/\1/' \
                                     -e 's/[[:space:]]*$//' \
                                     -e '1q' \
                             )
@@ -84,30 +74,6 @@ _todo()
     return 0
 }
 complete -F _todo todo.sh
-
 # If you define an alias (e.g. "t") to todo.sh, you need to explicitly enable
 # completion for it, too:
 #complete -F _todo t
-# It is recommended to put this line next to your alias definition in your
-# ~/.bashrc (or wherever else you're defining your alias). If you simply
-# uncomment it here, you will need to redo this on every todo.txt update!
-
-# If you have renamed the todo.sh executable, or if it is not accessible through
-# PATH, you need to add and use a wrapper completion function, like this:
-#_todoElsewhere()
-#{
-#    local _todo_sh='/path/to/todo2.sh'
-#    _todo "$@"
-#}
-#complete -F _todoElsewhere /path/to/todo2.sh
-
-# If you use aliases to use different configuration(s), you need to add and use
-# a wrapper completion function for each configuration if you want to complete
-# fron the actual configured task locations:
-#alias todo2='todo.sh -d "$HOME/todo2.cfg"'
-#_todo2()
-#{
-#    local _todo_sh='todo.sh -d "$HOME/todo2.cfg"'
-#    _todo "$@"
-#}
-#complete -F _todo2 todo2