e1c1c328a2
Instead of potentially falling back to the built-in action that a custom action was intended to override, but (e.g. due to file system reorganizations) now results in a broken link. The extension functionality that is then skipped may result in undesired results, but this may not be immedately obvious to the user (if the extension is not particularly verbose), so some data corruption could occur if this remains undetected. To avoid duplicating (or somehow extracting) all the built-in actions, simply detect _any_ broken symlink; i.e. offer a superset of the required functionality. So this would also complain about a broken symlink to a non-executable custom (auxiliary) file (rarely used) if that is mistakenly passed as a custom action (unlikely). Fixes #359
94 lines
2.6 KiB
Bash
Executable File
94 lines
2.6 KiB
Bash
Executable File
#!/bin/bash
|
|
|
|
test_description='custom actions functionality
|
|
|
|
This test covers the contract between todo.sh and custom actions.
|
|
'
|
|
. ./actions-test-lib.sh
|
|
. ./test-lib.sh
|
|
|
|
make_action "foo"
|
|
test_todo_session 'executable action' <<EOF
|
|
>>> todo.sh foo
|
|
custom action foo
|
|
EOF
|
|
|
|
chmod -x .todo.actions.d/foo
|
|
# On Cygwin, clearing the executable flag may have no effect, as the Windows ACL
|
|
# may still grant execution rights. In this case, we skip the test.
|
|
if [ -x .todo.actions.d/foo ]; then
|
|
SKIP_TESTS="${SKIP_TESTS}${SKIP_TESTS+ }t8000.2"
|
|
fi
|
|
test_todo_session 'nonexecutable action' <<EOF
|
|
>>> todo.sh foo
|
|
Usage: todo.sh [-fhpantvV] [-d todo_config] action [task_number] [task_description]
|
|
Try 'todo.sh -h' for more information.
|
|
=== 1
|
|
EOF
|
|
|
|
make_action "ls"
|
|
test_todo_session 'overriding built-in action' <<EOF
|
|
>>> todo.sh ls
|
|
custom action ls
|
|
|
|
>>> todo.sh command ls
|
|
--
|
|
TODO: 0 of 0 tasks shown
|
|
EOF
|
|
|
|
make_action "bad"
|
|
echo "exit 42" >> .todo.actions.d/bad
|
|
test_todo_session 'failing action' <<EOF
|
|
>>> todo.sh bad
|
|
custom action bad
|
|
=== 42
|
|
EOF
|
|
|
|
make_action
|
|
ln -s /actionsdir/doesnotexist/badlink .todo.actions.d/badlink
|
|
# On Cygwin, the Windows ACL may still grant execution rights. In this case, we
|
|
# skip the test.
|
|
if [ -x .todo.actions.d/badlink ]; then
|
|
SKIP_TESTS="${SKIP_TESTS}${SKIP_TESTS+ }t8000.6 t8000.7"
|
|
fi
|
|
test_todo_session 'broken symlink' <<EOF
|
|
>>> todo.sh badlink | sed "s#'[^']*\(\\.todo\\.actions\\.d/[^']\{1,\}\)'#'\1'#g"
|
|
Fatal Error: Broken link to custom action: '.todo.actions.d/badlink'
|
|
|
|
>>> todo.sh do >/dev/null
|
|
=== 1
|
|
EOF
|
|
|
|
make_action
|
|
mkdir .todo.actions.d/badfolderlink
|
|
ln -s /actionsdir/doesnotexist/badfolderlink .todo.actions.d/badfolderlink/badfolderlink
|
|
# On Cygwin, the Windows ACL may still grant execution rights. In this case, we
|
|
# skip the test.
|
|
if [ -x .todo.actions.d/badfolderlink/badfolderlink ]; then
|
|
SKIP_TESTS="${SKIP_TESTS}${SKIP_TESTS+ }t8000.8 t8000.9"
|
|
fi
|
|
test_todo_session 'broken symlink in folder' <<EOF
|
|
>>> todo.sh badfolderlink | sed "s#'[^']*\(\\.todo\\.actions\\.d/[^']\{1,\}\)'#'\1'#g"
|
|
Fatal Error: Broken link to custom action: '.todo.actions.d/badfolderlink/badfolderlink'
|
|
|
|
>>> todo.sh do >/dev/null
|
|
=== 1
|
|
EOF
|
|
|
|
make_action
|
|
ln -s /actionsdir/doesnotexist/do .todo.actions.d/do
|
|
# On Cygwin, the Windows ACL may still grant execution rights. In this case, we
|
|
# skip the test.
|
|
if [ -x .todo.actions.d/do ]; then
|
|
SKIP_TESTS="${SKIP_TESTS}${SKIP_TESTS+ }t8000.10 t8000.11"
|
|
fi
|
|
test_todo_session 'broken symlink overrides built-in action' <<EOF
|
|
>>> todo.sh do | sed "s#'[^']*\(\\.todo\\.actions\\.d/[^']\{1,\}\)'#'\1'#g"
|
|
Fatal Error: Broken link to custom action: '.todo.actions.d/do'
|
|
|
|
>>> todo.sh do >/dev/null
|
|
=== 1
|
|
EOF
|
|
|
|
test_done
|